Michael Pasternak has posted comments on this change. Change subject: engine: cpu host feature ......................................................................
Patch Set 9: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 424: <xs:enumeration value="HOST_PASSTHROUGH"/> Line 425: <xs:enumeration value="HOST_MODEL"/> Line 426: </xs:restriction> Line 427: </xs:simpleType> Line 428: we not exposing enums in api, only strings, please see how all other enums treated Line 429: <xs:complexType name="CPU"> Line 430: <xs:sequence> Line 431: <xs:element name="topology" type="CpuTopology" minOccurs="0" maxOccurs="1"/> Line 432: <xs:element name="level" type="xs:int" minOccurs="0"/> -- To view, visit http://gerrit.ovirt.org/9753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
