Maor Lipchuk has posted comments on this change.
Change subject: restapi: Added "scan" to disks resource to import clones
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ScanDomainQuery.java
Line 21: * @author Ricky Hopper
Line 22: *
Line 23: * @param <P>
Line 24: */
Line 25: public class ScanDomainQuery<P extends
StorageDomainQueryParametersBase> extends QueriesCommandBase<P> {
Can u please add a test for that query
Line 26:
Line 27: private static final Log logger =
LogFactory.getLog(ScanDomainQuery.class);
Line 28:
Line 29: public ScanDomainQuery(P parameters) {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
Line 140: VdcQueryReturnValue newImagesReturn =
runQuery(VdcQueryType.ScanDomain, scanQueryParameters);
Line 141: if (newImagesReturn.getSucceeded()) {
Line 142:
Line 143: // Get a reference to the VDS broker so we can run
commands against the backend.
Line 144: VDSBrokerFrontend vdsBroker =
getBackend().getResourceManager();
I know that vds commands are usually called from the engine layer, since we
will probably want to use the same logic for the GUI also.
Line 145: @SuppressWarnings("unchecked")
Line 146: List<Guid> newImages = (List<Guid>)
newImagesReturn.getReturnValue();
Line 147: for (Guid newImage : newImages) {
Line 148:
--
To view, visit http://gerrit.ovirt.org/9603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6236e563d38ee1a793bd94ff60587f19b3010d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Chris Morrissey <cmorr...@netapp.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
