Moti Asayag has posted comments on this change. Change subject: engine: Modify Network Assign to Cluster Command permissions ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java Line 162: } Line 163: Line 164: @Override Line 165: public List<PermissionSubject> getPermissionCheckSubjects() { Line 166: That means modifying the MLA to accept 2 lists. I'll add the change to CommandBase in a separate patch and modify this one to rely on it. Line 167: if (networkExists()) { Line 168: return Collections.singletonList(new PermissionSubject(getParameters().getVdsGroupId(), Line 169: VdcObjectType.VdsGroups, Line 170: ActionGroup.CONFIGURE_CLUSTER_NETWORK)); -- To view, visit http://gerrit.ovirt.org/9540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches