Arik Hadas has uploaded a new change for review.
Change subject: webadmin: fix layout of multiple lines conf msgs
......................................................................
webadmin: fix layout of multiple lines conf msgs
Fix the layout of messages in some confirmations dialogs that should be
splitted over multiple lines (such as in the "import vm" confirmation
dialog).
The problem was that the widget which is used to contain those messages
is Label, thus the '\n' characters in the message are ignored, and the
message is presented in a single long line.
This patch solves the problem by replacing the '\n' characters in the
message with "<br/>" tags and setting the message as HTML, as done in
RemoveConfirmationPopupView#setNote.
Change-Id: I1576b7576cf93ba9e525f20261d423fd4c0721b0
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/9989/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
index 6faec2e..458ba94 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractConfirmationPopupView.java
@@ -19,7 +19,7 @@
@Override
public void setMessage(String message) {
- messageLabel.setText(message);
+ messageLabel.getElement().setInnerHTML(message != null ?
message.replace("\n", "<br/>") : "");//$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
}
}
--
To view, visit http://gerrit.ovirt.org/9989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1576b7576cf93ba9e525f20261d423fd4c0721b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
