Michael Pasternak has posted comments on this change.
Change subject: restapi: VM-runtime-only information presented after VM goes
down (#869682)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 327:
model.getGuestInfo().getIps().getIPs().add(ip);
Line 328: }
Line 329: }
Line 330: }
Line 331: if (entity.getDynamicData().getLastStartTime() != null) {
you should not refer to DynamicData directly, instead do
entity.getLastStartTime()
Line 332:
model.setStartTime(DateMapper.map(entity.getDynamicData().getLastStartTime(),
null));
Line 333: }
Line 334: model.setDisplay(new Display());
Line 335:
model.getDisplay().setType(map(entity.getDynamicData().getdisplay_type(),
null));
Line 328: }
Line 329: }
Line 330: }
Line 331: if (entity.getDynamicData().getLastStartTime() != null) {
Line 332:
model.setStartTime(DateMapper.map(entity.getDynamicData().getLastStartTime(),
null));
same
Line 333: }
Line 334: model.setDisplay(new Display());
Line 335:
model.getDisplay().setType(map(entity.getDynamicData().getdisplay_type(),
null));
Line 336: model.getDisplay().setAddress(entity.getdisplay_ip());
Line 331: if (entity.getDynamicData().getLastStartTime() != null) {
Line 332:
model.setStartTime(DateMapper.map(entity.getDynamicData().getLastStartTime(),
null));
Line 333: }
Line 334: model.setDisplay(new Display());
Line 335:
model.getDisplay().setType(map(entity.getDynamicData().getdisplay_type(),
null));
you should not refer to DynamicData directly, instead do
entity.getdisplay_type()
Line 336: model.getDisplay().setAddress(entity.getdisplay_ip());
Line 337: Integer displayPort = entity.getdisplay();
Line 338: model.getDisplay().setPort(displayPort==null ||
displayPort==-1 ? null : displayPort);
Line 339: Integer displaySecurePort =
entity.getdisplay_secure_port();
Line 344: model.getOs().getBoot().add(boot);
Line 345: }
Line 346: }
Line 347: if (entity.getdefault_display_type() != null) {
Line 348: model.setDisplay(new Display());
what about adding getdefault_display_type()?
Line 349: }
Line 350: }
Line 351: if (model.getDisplay() != null) {
Line 352:
model.getDisplay().setMonitors(entity.getnum_of_monitors());
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-06 12:44:40 -0500
Line 4: Commit: Ravi Nori <rn...@redhat.com>
Line 5: CommitDate: 2012-12-02 15:06:44 +0200
Line 6:
Line 7: restapi: VM-runtime-only information presented after VM goes down
(#869682)
please always add link to the BZ
Line 8:
Line 9: VM-runtime-only display information is presented by api after VM goes
down
Line 10:
Line 11: The runtime only information like address, port, secure_port and
start_time
--
To view, visit http://gerrit.ovirt.org/9090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie36fa8049c8ddad483e7e16f13a3d0a029f8f218
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
