Selvasundaram has posted comments on this change.

Change subject: engine: Passwordless ssh status query
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetPasswordlessSshStatusVDSCommand.java
Line 15:                 
getBroker().glusterValidateSshConnection(getParameters().getRemoteServer(),
Line 16:                         getParameters().getFingerprint(),
Line 17:                         getParameters().getUserName());
Line 18:         ProceedProxyReturnValue();
Line 19:         setReturnValue(getReturnValue());
It should be true. 'vdsm' returns error on failure.
Line 20:     }
Line 21: 


--
To view, visit http://gerrit.ovirt.org/8447
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53a3874cdf4fbcb21f6e6c146db76ff90a62f836
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to