Selvasundaram has posted comments on this change.
Change subject: engine: Passwordless ssh status query
......................................................................
Patch Set 3: (5 inline comments)
Comments are incorporated
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetPasswordlessSshStatusQuery.java
Line 31:
getParameters().getRemoteServerFingerpirnt(),
Line 32: getParameters().getUserName()));
Line 33:
getQueryReturnValue().setSucceeded(returnValue.getSucceeded());
Line 34: if (!returnValue.getSucceeded()) {
Line 35:
getQueryReturnValue().setExceptionString(returnValue.getVdsError().getMessage());
Done
Line 36: }
Line 37: } catch (Exception e) {
Line 38: log.error(e.getMessage());
Line 39: getQueryReturnValue().setSucceeded(false);
Line 32: getParameters().getUserName()));
Line 33:
getQueryReturnValue().setSucceeded(returnValue.getSucceeded());
Line 34: if (!returnValue.getSucceeded()) {
Line 35:
getQueryReturnValue().setExceptionString(returnValue.getVdsError().getMessage());
Line 36: }
Done
Line 37: } catch (Exception e) {
Line 38: log.error(e.getMessage());
Line 39: getQueryReturnValue().setSucceeded(false);
Line 40: getQueryReturnValue().setExceptionString(e.getMessage());
Line 40: getQueryReturnValue().setExceptionString(e.getMessage());
Line 41: }
Line 42: }
Line 43:
Line 44: public VDSBrokerFrontend getBackendResourceManager() {
Done
Line 45: return Backend.getInstance()
Line 46: .getResourceManager();
Line 47: }
Line 48:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/PasswordlessSshVDSParameters.java
Line 15: private String fingerprint;
Line 16:
Line 17: private String userName;
Line 18:
Line 19: private String password;
Password field is consumed by ConfigPasswordlessSsh VDS Command
(http://gerrit.ovirt.org/#/c/8453/).
Line 20:
Line 21: public PasswordlessSshVDSParameters(Guid serverId,
Line 22: String remoteServer,
Line 23: String fingerprint,
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetPasswordlessSshStatusVDSCommand.java
Line 10: super(parameters);
Line 11: }
Line 12:
Line 13: @Override
Line 14: protected StatusForXmlRpc getReturnStatus() {
Removed
Line 15: return status.mStatus;
Line 16: }
Line 17:
Line 18: @Override
--
To view, visit http://gerrit.ovirt.org/8447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53a3874cdf4fbcb21f6e6c146db76ff90a62f836
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
