Shireesh Anjal has posted comments on this change.

Change subject: tools: adding gluster logs
......................................................................


Patch Set 1:

I'm not an expert in python, or the log-collector project, but looking at the 
sources you've modified, I would recommend adding the gluster-enabled flag 
inside the Cluster class present in hypervisors.py, and returning the whole 
cluster object instead of just cluster.name from the get_sortable method.

--
To view, visit http://gerrit.ovirt.org/9765
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756aea7457c2cd7c9c7b0b842149110f5f392abb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to