Bala.FA has posted comments on this change. Change subject: tools: adding gluster logs ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File src/rhev/helper/hypervisors.py Line 112: for dc in self.datacenters Line 113: for cluster in dc.clusters Line 114: for host in cluster.hosts] Line 115: Line 116: return (self.gluster_enabled_clusters, set(sortable_data)) You could have another method to return gluster_enabled_clusters than patching here Line 117: Line 118: Line 119: def _initialize_api(hostname, username, password, ca, insecure): Line 120: """ -- To view, visit http://gerrit.ovirt.org/9765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I756aea7457c2cd7c9c7b0b842149110f5f392abb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avish...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
