Roy Golan has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
pls javadoc this class will be deprecated once jdk7 will be in use due to
tryWithResources - Statement,Result,Connection extends AutoClosable in 7
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java
Line 43: public static void closeQuietly(Connection connection) {
Line 44: if (connection != null) {
Line 45: try {
Line 46: connection.close();
Line 47:
redundant line
Line 48: } catch (SQLException e) {
Line 49: }
Line 50: }
Line 51: }
--
To view, visit http://gerrit.ovirt.org/9740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c4e156123
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
