Mike Kolesnik has posted comments on this change.

Change subject: engine: Introduce permissions on network
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
Line 495:         
assertTrue(name.equals(dbFacade.getEntityNameByIdAndType(DISK_ID, 
VdcObjectType.Disk)));
Line 496:     }
Line 497: 
Line 498:     @Test
Line 499:     public void testGetEntityNameByIdAndTypeForVmInterface() {
Shouldn't test method name also change?
Line 500:         Network network = dbFacade.getNetworkDao().get(NETWORK_ID);
Line 501:         assertNotNull(network);
Line 502:         String name = network.getName();
Line 503:         
assertTrue(name.equals(dbFacade.getEntityNameByIdAndType(NETWORK_ID, 
VdcObjectType.Network)));


--
To view, visit http://gerrit.ovirt.org/9533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If25d943cc3b7256b86a8c53ce8d37bb3b928521b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to