Ravi Nori has posted comments on this change.
Change subject: tools: DB connections improvement at notifier
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
Line 208: } catch (SQLException e) {
Line 209: log.error("Failed to release statement of
event_audit_log_subscriber", e);
Line 210: throw e;
Line 211: }
Line 212: }
Should we consider utility functions to close rs, ps and connection that can be
called from all the places where we need to close them. Just a thought.
Line 213: if (connection != null) {
Line 214: try {
Line 215: connection.close();
Line 216: } catch (SQLException e) {
--
To view, visit http://gerrit.ovirt.org/9735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c2e056122
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
