Moti Asayag has posted comments on this change.
Change subject: tools: DB connections improvement at notifier
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
Line 207: ps.close();
Line 208: } catch (SQLException e) {
Line 209: log.error("Failed to release statement of
event_audit_log_subscriber", e);
Line 210: throw e;
Line 211: }
please close the connection as well.
Line 212: }
Line 213: }
Line 214: DbUser dbUser = null;
Line 215: for (event_audit_log_subscriber
eventSubscriber:eventSubscribers) {
--
To view, visit http://gerrit.ovirt.org/9735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c2e056122
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
