Allon Mureinik has posted comments on this change. Change subject: core: Remove SQL Server specific code ......................................................................
Patch Set 2: @Juan: "Regarding the method sin the DbEngineDialect interface I also want to remove those methods, but removing some of them requires many changes. I prefer to do it in different patches, if you don't mind." - Agree. I do, however, suggest to fix their TODO comment, so it won't reference a class that no longer exists in the system. "Regarding the KerberosUpgrade class I wonder if it is used at all. The fact that it loads the SQLServer driver is a good indication that nobody is using it. May I remove it (in a different patch)?" Please do! -- To view, visit http://gerrit.ovirt.org/9580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb0eb97dfe5554f2606e16b85705fbf51e571bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
