Allon Mureinik has posted comments on this change. Change subject: core: Remove SQL Server engine dialect ......................................................................
Patch Set 1: Also note the following: 1. The DbEngineDialect interface has a bunch of methods commented with: "TODO: Remove this method once we don't use SqlServer anymore, since it's a needed only for SqlServer Compatibility." Please remove them too. 2. KerberosUpgrade register's Microsoft's SQL Server driver - I assume that too should be removed, not sure if it's a part of this patch or not. -- To view, visit http://gerrit.ovirt.org/9580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdb0eb97dfe5554f2606e16b85705fbf51e571bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
