Alona Kaplan has posted comments on this change.
Change subject: core: HotPlugNicVDSCommand should send "linkState" to the vdsm.
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java
Line 39: map.add(VdsProperties.Device, VmDeviceType.BRIDGE.getName());
Line 40: map.add(VdsProperties.mac_addr, nic.getMacAddress());
Line 41: if (nic.getNetworkName() != null) {
Line 42: map.add(VdsProperties.network, nic.getNetworkName());
Line 43: }
Done
Line 44: map.add(VdsProperties.linkState, nic.isLinked() ? "up" :
"down");
Line 45: addAddress(map, vmDevice.getAddress());
Line 46: map.add(VdsProperties.SpecParams, vmDevice.getSpecParams());
Line 47: map.add(VdsProperties.nic_type,
VmInterfaceType.forValue(nic.getType()).name());
....................................................
Commit Message
Line 11: Otherwise-
Line 12: 'linkState-> down' should be sent to the vdsm
Line 13:
Line 14: - If network name is null it should be sent.
Line 15: - CanDo shpuld allow null network.
Done
Line 16:
Line 17: Change-Id: I127fc3202702f8cb1920990eb77d9fbccdb9804b
--
To view, visit http://gerrit.ovirt.org/9519
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I127fc3202702f8cb1920990eb77d9fbccdb9804b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
