Moti Asayag has posted comments on this change. Change subject: core: HotPlugNicVDSCommand should send "linkState" to the vdsm. ......................................................................
Patch Set 20: (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-12-09 19:39:12 +0200 Line 4: Commit: Mike Kolesnik <mkole...@redhat.com> Line 5: CommitDate: 2012-12-20 11:16:09 +0200 Line 6: Line 7: core: HotPlugNicVDSCommand should send "linkState" to the vdsm. s/linkState/linkActive Line 8: Line 9: - If "linked" property on VmNetworkInterface is true Line 10: 'linkState-> up' should be sent to the vdsm Line 11: Otherwise- Line 6: Line 7: core: HotPlugNicVDSCommand should send "linkState" to the vdsm. Line 8: Line 9: - If "linked" property on VmNetworkInterface is true Line 10: 'linkState-> up' should be sent to the vdsm please chance linkState with up/down to linkActive true/false Line 11: Otherwise- Line 12: 'linkState-> down' should be sent to the vdsm Line 13: Line 14: - If network name is null it should be sent. -- To view, visit http://gerrit.ovirt.org/9519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127fc3202702f8cb1920990eb77d9fbccdb9804b Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
