Michael Pasternak has posted comments on this change.
Change subject: restapi: #839205 Display Host Hooks
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java
Line 27: if (parent.generateHookId(hook.getEventName(),
hook.getName(), hook.getMd5()).equals(guid)) {
Line 28: return hook;
Line 29: }
Line 30: }
Line 31: return null;
should return 404, not NULL.
Line 32: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java
Line 41: Hooks hooks = new Hooks();
Line 42: for (Map.Entry<String, HashMap<String, HashMap<String,
String>>> keyValuePair : dictionary.entrySet()) { // events
Line 43: for (Map.Entry<String, HashMap<String, String>>
keyValuePair1 : keyValuePair.getValue() // hooks
Line 44: .entrySet()) {
Line 45: Hook hook = createHook(keyValuePair, keyValuePair1);
why this code ^ is not in Mapper?
Line 46: hooks.getHooks().add(hook);
Line 47: }
Line 48: }
Line 49: return hooks;
--
To view, visit http://gerrit.ovirt.org/9478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
