Michael Pasternak has posted comments on this change.
Change subject: restapi: #839205 Display Host Hooks
......................................................................
Patch Set 2: (1 inline comment)
please also implement BackendHostHookResourceTest
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java
Line 42: return inject(new BackendHostHookResource(id, this));
Line 43: }
Line 44:
Line 45: @Override
Line 46: protected Response performRemove(String id) {
we should be splitting AbstractBackendCollectionResource to
AbstractBackendCollectionResource and AbstractBackendReadOnlyCollectionResource
where AbstractBackendCollectionResource is extending
AbstractBackendReadOnlyCollectionResource
and BackendHostHooksResource should inherit from the
AbstractBackendReadOnlyCollectionResource, this way readonly collections won't
have to implement false performRemove()
Line 47: // not in use
Line 48: return null;
Line 49: }
Line 50:
--
To view, visit http://gerrit.ovirt.org/9478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
