Moti Asayag has posted comments on this change.
Change subject: core: RunVm should send "linkState" to the vdsm.
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 783:
Line 784: // Checking that the interfaces are all configured
Line 785: // If network linking is supported, interfaces with no
network are allowed.
Line 786: // Otherwise, canDoAction should be thrown.
Line 787: returnValue = isVmInterfacesConfigured(interfaceNetworkMap);
Please move this to be the second line of the current function since the rest
of the processing will not be required in case this validation fails.
e.g.
if (!isVmInterfacesConfigured(interfaceNetworkMap)){
return false;
}
here comes the rest of the validation (no need for returnValue at all):
Set<String> interfaceNetworkNames = interfaceNetworkMap.keySet();
List<Network> clusterNetworks =
getNetworkDAO().getAllForCluster(getVm().getvds_group_id());
...
Line 788:
Line 789: // Remove interfaces with no network
Line 790: interfaceNetworkMap.remove(null);
Line 791:
--
To view, visit http://gerrit.ovirt.org/9518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9805b18c364685a6533b89cfa31ae0575a00ea5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
