Allon Mureinik has posted comments on this change. Change subject: engine: Improving almost all retrieves of storage_domains object in the system ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/dbscripts/create_views.sql Line 255: storage_domain_static.storage_domain_type as storage_domain_type, Line 256: storage_domain_static.storage_domain_format_type as storage_domain_format_type, Line 257: storage_domain_static.last_time_used_as_master as last_time_used_as_master, Line 258: storage_pool_iso_map.owner as owner, Line 259: fn_get_storage_domain_shared_status_by_domain_id(storage_domain_static.id,storage_pool_iso_map.status,storage_domain_static.storage_domain_type) as storage_domain_shared_status, bah, missed the ")" - this milion fields views are impossible... Line 260: storage_domain_static.recoverable as recoverable Line 261: FROM storage_domain_static Line 262: INNER JOIN storage_domain_dynamic ON storage_domain_static.id = storage_domain_dynamic.id Line 263: LEFT OUTER JOIN storage_pool_iso_map ON storage_domain_static.id = storage_pool_iso_map.storage_id -- To view, visit http://gerrit.ovirt.org/9511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I617a631c63cd38f058e6c0711dea3a43062874fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
