Yair Zaslavsky has posted comments on this change. Change subject: engine: Improving almost all retrieves of storage_domains object in the system ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Fix trailing white spaces, besides that - looks good to me. As we discussed between us - the "create temp table" part should be revisited. .................................................... File backend/manager/dbscripts/create_functions.sql Line 361: DECLARE Line 362: v_result INTEGER; Line 363: v_rowsCount INTEGER; Line 364: v_status INTEGER; Line 365: BEGIN TWS, please remove Line 366: if (v_storage_domain_type != 2) then Line 367: if (v_storage_status is null) then Line 368: v_result := 0; Line 369: else -- To view, visit http://gerrit.ovirt.org/9511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I617a631c63cd38f058e6c0711dea3a43062874fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
