Maor Lipchuk has submitted this change and it was merged. Change subject: core:End failed live snapshot with warning. ......................................................................
core:End failed live snapshot with warning. Engine fails to create Live-Snapshot during power off of VM. This is since the KVM process might be killed in the middle of the process and the synchronization between the engine VM and the KVM process in the VDSM are not reliable and could be racy. The proposed solution is to avoid the rollback of the entire operation, but instead finish the command with success, and add an appropriate audit log. That way will allow the VM to be configured to the new snapshot at the next run. Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Signed-Off-By: Maor Lipchuk <mlipc...@redhat.com> Bug-Url: https://bugzilla.redhat.com/870928 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 15 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
