Asaf Shakarchi has posted comments on this change.

Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 552:         
mSeverities.put(AuditLogType.CANNOT_HIBERNATE_RUNNING_VMS_AFTER_CLUSTER_CPU_UPGRADE,
 AuditLogSeverity.WARNING);
Line 553:         mSeverities.put(AuditLogType.HA_VM_FAILED, 
AuditLogSeverity.ERROR);
Line 554:         mSeverities.put(AuditLogType.HA_VM_RESTART_FAILED, 
AuditLogSeverity.ERROR);
Line 555:         mSeverities.put(AuditLogType.USER_FAILED_ATTACH_DISK_TO_VM, 
AuditLogSeverity.ERROR);
Line 556: 
I guess so, IIRC there should be some warnings when server comes up for any 
enum that is not defined.
Line 557:     }
Line 558: 
Line 559:     private static void initClusterSeverities() {
Line 560:         mSeverities.put(AuditLogType.USER_ADD_VDS_GROUP, 
AuditLogSeverity.NORMAL);


--
To view, visit http://gerrit.ovirt.org/9464
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0202766ecae08a0bfa78a149f089d3e4bf96f52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to