Gilad Chaplik has posted comments on this change. Change subject: tools: engine-config cleanup 2.2 SupportCustomProperties ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 660: select fn_db_delete_config_value('LocalStorageEnabled','3.2'); Line 661: select fn_db_delete_config_value('SupportCustomProperties','2.2'); Line 662: select fn_db_delete_config_value('SupportCustomProperties','3.0'); Line 663: select fn_db_delete_config_value('SupportCustomProperties','3.1'); Line 664: select fn_db_delete_config_value('SupportCustomProperties','3.2'); agree, but I think it should be done in a separate patch. it's not related.. (overload for fn_db_delete_config_value that gets only value name). Line 665: ------------------------------------------------------------------------------------ Line 666: -- Split config section Line 667: -- The purpose of this section is to treat config option that was once Line 668: -- general, and should now be version-specific. -- To view, visit http://gerrit.ovirt.org/9488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e156799017f7bbf35c2707c09aa72bb55273cb2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches