Allon Mureinik has posted comments on this change.
Change subject: core: cleanup Vm
......................................................................
Patch Set 1: (19 inline comments)
see inline
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 400: public void setStateless(boolean value) {
Line 401: mVmStatic.setis_stateless(value);
Line 402: }
Line 403:
Line 404: public DisplayType getdefault_display_type() {
why aren't you changing this methods name too?
Line 405: return mVmStatic.getdefault_display_type();
Line 406: }
Line 407:
Line 408: public void setdefault_display_type(DisplayType value) {
Line 404: public DisplayType getdefault_display_type() {
Line 405: return mVmStatic.getdefault_display_type();
Line 406: }
Line 407:
Line 408: public void setdefault_display_type(DisplayType value) {
why aren't you changing this methods name too?
Line 409: mVmStatic.setdefault_display_type(value);
Line 410: }
Line 411:
Line 412: public int getpriority() {
Line 407:
Line 408: public void setdefault_display_type(DisplayType value) {
Line 409: mVmStatic.setdefault_display_type(value);
Line 410: }
Line 411:
why aren't you changing this methods name too?
Line 412: public int getpriority() {
Line 413: return mVmStatic.getpriority();
Line 414: }
Line 415:
Line 411:
Line 412: public int getpriority() {
Line 413: return mVmStatic.getpriority();
Line 414: }
Line 415:
why aren't you changing this methods name too?
Line 416: public void setpriority(int value) {
Line 417: mVmStatic.setpriority(value);
Line 418: }
Line 419:
Line 415:
Line 416: public void setpriority(int value) {
Line 417: mVmStatic.setpriority(value);
Line 418: }
Line 419:
why aren't you changing this methods name too?
Line 420: public String getiso_path() {
Line 421: return mVmStatic.getiso_path();
Line 422: }
Line 423:
Line 419:
Line 420: public String getiso_path() {
Line 421: return mVmStatic.getiso_path();
Line 422: }
Line 423:
why aren't you changing this methods name too?
Line 424: public void setiso_path(String value) {
Line 425: mVmStatic.setiso_path(value);
Line 426: }
Line 427:
Line 423:
Line 424: public void setiso_path(String value) {
Line 425: mVmStatic.setiso_path(value);
Line 426: }
Line 427:
why aren't you changing this methods name too?
Line 428: public OriginType getorigin() {
Line 429: return mVmStatic.getorigin();
Line 430: }
Line 431:
Line 427:
Line 428: public OriginType getorigin() {
Line 429: return mVmStatic.getorigin();
Line 430: }
Line 431:
why aren't you changing this methods name too?
Line 432: public void setorigin(OriginType value) {
Line 433: mVmStatic.setorigin(value);
Line 434: }
Line 435:
Line 431:
Line 432: public void setorigin(OriginType value) {
Line 433: mVmStatic.setorigin(value);
Line 434: }
Line 435:
why aren't you changing this methods name too?
Line 436: public String getinitrd_url() {
Line 437: return mVmStatic.getinitrd_url();
Line 438: }
Line 439:
Line 435:
Line 436: public String getinitrd_url() {
Line 437: return mVmStatic.getinitrd_url();
Line 438: }
Line 439:
why aren't you changing this methods name too?
Line 440: public void setinitrd_url(String value) {
Line 441: mVmStatic.setinitrd_url(value);
Line 442: }
Line 443:
Line 439:
Line 440: public void setinitrd_url(String value) {
Line 441: mVmStatic.setinitrd_url(value);
Line 442: }
Line 443:
why aren't you changing this methods name too?
Line 444: public String getkernel_url() {
Line 445: return mVmStatic.getkernel_url();
Line 446: }
Line 447:
Line 443:
Line 444: public String getkernel_url() {
Line 445: return mVmStatic.getkernel_url();
Line 446: }
Line 447:
why aren't you changing this methods name too?
Line 448: public void setkernel_url(String value) {
Line 449: mVmStatic.setkernel_url(value);
Line 450: }
Line 451:
Line 447:
Line 448: public void setkernel_url(String value) {
Line 449: mVmStatic.setkernel_url(value);
Line 450: }
Line 451:
why aren't you changing this methods name too?
Line 452: public String getkernel_params() {
Line 453: return mVmStatic.getkernel_params();
Line 454: }
Line 455:
Line 451:
Line 452: public String getkernel_params() {
Line 453: return mVmStatic.getkernel_params();
Line 454: }
Line 455:
why aren't you changing this methods name too?
Line 456: public void setkernel_params(String value) {
Line 457: mVmStatic.setkernel_params(value);
Line 458: }
Line 459:
Line 458: }
Line 459:
Line 460: private NGuid mVmPoolId;
Line 461: private String mVmPoolName;
Line 462:
why aren't you changing this methods name too?
Line 463: public VMStatus getstatus() {
Line 464: return this.mVmDynamic.getstatus();
Line 465: }
Line 466:
Line 462:
Line 463: public VMStatus getstatus() {
Line 464: return this.mVmDynamic.getstatus();
Line 465: }
Line 466:
why aren't you changing this methods name too?
Line 467: public void setstatus(VMStatus value) {
Line 468: this.mVmDynamic.setstatus(value);
Line 469: }
Line 470:
Line 466:
Line 467: public void setstatus(VMStatus value) {
Line 468: this.mVmDynamic.setstatus(value);
Line 469: }
Line 470:
why aren't you changing this methods name too?
Line 471: public String getvm_ip() {
Line 472: return this.mVmDynamic.getvm_ip();
Line 473: }
Line 474:
Line 471: public String getvm_ip() {
Line 472: return this.mVmDynamic.getvm_ip();
Line 473: }
Line 474:
Line 475: public void setvm_ip(String value) {
why aren't you changing this methods name too?
Line 476: this.mVmDynamic.setvm_ip(value);
Line 477: }
Line 478:
Line 479: public String getvm_host() {
Line 475: public void setvm_ip(String value) {
Line 476: this.mVmDynamic.setvm_ip(value);
Line 477: }
Line 478:
Line 479: public String getvm_host() {
why aren't you changing this methods name too?
Line 480: String vmHost = this.mVmDynamic.getvm_host();
Line 481: if (!StringHelper.isNullOrEmpty(this.getvm_ip())) {
Line 482: this.mVmDynamic.setvm_host(getvm_ip());
Line 483: } else {
--
To view, visit http://gerrit.ovirt.org/9394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia02ddd858626553eca5de2310e8921cfac71957c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
