Doron Fediuck has posted comments on this change.
Change subject: core: correcting max memory for scheduling VMs field
......................................................................
Patch Set 3: (1 inline comment)
Sorry, but still missing something here. See inline.
My bad for missing it earlier.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 1168:
Line 1169: public void calculateFreeVirtualMemory() {
Line 1170: if (getmem_commited() != null && getphysical_mem_mb() !=
null && getreserved_mem() != null && getguest_overhead() != null &&
getpending_vmem_size() != null) {
Line 1171: maxSchedulingMemory = (getmax_vds_memory_over_commit() *
getphysical_mem_mb() / 100.0f) -
Line 1172: (getmem_commited() + getreserved_mem() +
getguest_overhead() + getpending_vmem_size());
Sorry for missing it earlier, but this is the same calc we have in
org.ovirt.engine.core.bll.RunVmCommandBase.hasMemoryToRunVM
double vdsCurrentMem = curVds.getmem_commited() + curVds.getpending_vmem_size()
+ curVds.getguest_overhead() + curVds.getreserved_mem() +
vm.getMinAllocatedMem();
So it looks like we still miss something here, and it would be much better if
we can unify both.
Line 1173: // avoid negative values
Line 1174: maxSchedulingMemory = maxSchedulingMemory > 0 ?
maxSchedulingMemory : 0;
Line 1175: }
Line 1176: }
--
To view, visit http://gerrit.ovirt.org/8367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7be5683f2ae708dff7f59bba194b3ea05935bcc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Amador Pahim <apa...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
