Moti Asayag has posted comments on this change. Change subject: engine Extract Vlan Id Validation (#871864) ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2012-11-18 18:07:22 +0200 Line 4: Commit: Muli Salem <msa...@redhat.com> Line 5: CommitDate: 2012-11-18 18:32:35 +0200 Line 6: Line 7: engine Extract Vlan Id Validation (#871864) please add colon after engine. Line 8: Line 9: This patch extracts repetitive code to the mutual parent Line 10: class of AddNetworkCommand and UpdateNetworkCommand. Line 11: -- To view, visit http://gerrit.ovirt.org/9312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
