Michael Pasternak has posted comments on this change. Change subject: restapi: Inherited perms are not seen via RESTAPI (#871365) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java Line 214 Line 215 Line 216 Line 217 Line 218 why did you removed VM permissions?, you should be adding Disk permissions here .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java Line 12: import org.ovirt.engine.core.common.action.HotPlugDiskToVmParameters; Line 13: import org.ovirt.engine.core.common.action.VdcActionType; Line 14: import org.ovirt.engine.core.compat.Guid; Line 15: Line 16: import static org.ovirt.engine.api.restapi.resource.BackendNicsResource.SUB_COLLECTIONS; note SUB_COLLECTIONS poins here on BackendNicsResource.SUB_COLLECTIONS, you should be using BackendVmDisksResource.SUB_COLLECTIONS adding "permissions" to it Line 17: import org.ovirt.engine.core.common.VdcObjectType; Line 18: import org.ovirt.engine.core.common.queries.GetPermissionsForObjectParameters; Line 19: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 20: -- To view, visit http://gerrit.ovirt.org/9243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1a05d64ed61ae2bcf813b926bb548842bada237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
