Roy Golan has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 382:
Line 383: readGeneralData(content);
Line 384: }
Line 385:
Line 386: protected void readSnapshotsSection(XmlNode section) {
I thought about asking you to make this abstract but the trade-off it to add
null implementation in OvfTemplate reader so in the end its the same.
So my only comment is just to make it a javadoc as well and to add @Override in
the implementing classes because its missing
Line 387: // The snapshot section only has meaning for VMs, and is
overridden in OvfVmReader.
Line 388: }
Line 389:
Line 390: protected abstract void readGeneralData(XmlNode content);
--
To view, visit http://gerrit.ovirt.org/9304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
