Allon Mureinik has uploaded a new change for review. Change subject: core: OvfReader cleanup - document empty blocks ......................................................................
core: OvfReader cleanup - document empty blocks Documented the empty implementation of buildNetworks() and readSnapshostsSection(String) to avoid warnings by code analysis tools (e.g., Eclipse IDE's built it inspection feature). Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Relates-To: https://bugzilla.redhat.com/72506 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/9304/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java index d86bbe2..63c65ed 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java @@ -85,6 +85,7 @@ @Override public void BuildNetwork() { + // No implementation - networks aren't read from the OVF. } protected long GigabyteToBytes(long gb) { @@ -383,7 +384,7 @@ } protected void readSnapshotsSection(XmlNode section) { - + // The snapshot section only has meaning for VMs, and is overridden in OvfVmReader. } protected abstract void readGeneralData(XmlNode content); -- To view, visit http://gerrit.ovirt.org/9304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
