Moti Asayag has posted comments on this change.
Change subject: webadmin: Network main tab is not visible in some tree
selection.
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 597: networkList.setIsAvailable(model.getType() ==
SystemTreeItemType.Network
Line 598: || model.getType() == SystemTreeItemType.Networks
Line 599: || model.getType() == SystemTreeItemType.System ||
model.getType() == SystemTreeItemType.DataCenter
Line 600: || model.getType() == SystemTreeItemType.Cluster ||
model.getType() == SystemTreeItemType.Host);
Line 601:
Referring to Host should be omitted from this patch as its depended patch deals
only with data-center and cluster.
Please update commit message accordingly.
Line 602: // Select a default item depending on system tree selection.
Line 603: ListModel oldSelectedItem = getSelectedItem();
Line 604:
Line 605: // Do not Change Tab if the Selection is the Reports
Line 1150: }
Line 1151: else if (networkList.IsSearchStringMatch(source))
Line 1152: {
Line 1153: prefix.argvalue =
Line 1154: StringFormat.format("Network: host =
%1$s", model.getTitle()); //$NON-NLS-1$
same as above
Line 1155: }
Line 1156: }
Line 1157: break;
Line 1158:
--
To view, visit http://gerrit.ovirt.org/9077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
