Eli Mesika has posted comments on this change.
Change subject: [WIP] core: Distingushing between entity and vdsm task ids
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1520_add_vdsm_task_id_to_async_tasks.sql
Line 1: select fn_db_add_column('async_tasks', 'vdsm_task_id', 'UUID DEFAULT
NULL');
Line 2: DROP INDEX if exists IDX_vdsm_task_id;
Line 3: CREATE INDEX IDX_vdsm_task_id ON async_tasks(vdsm_task_id);
Yair, did you test that this is working.
I think that you must split it to 2 upgrade scripts because it is all done in
one transaction , so , you will fail on the index creation since the new column
was added only to the transaction log and not to the table
Apart from that , the DROP is redundant since scripts are not re-entrant any
more.
In short
1st line should be in 03_01_1520
2nd line should be deleted
3rd line should be in 03_01_1530
--
To view, visit http://gerrit.ovirt.org/9230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd8f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
