Shireesh Anjal has posted comments on this change. Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint() ......................................................................
Patch Set 2: Now I get what you were trying to say! You are right - even the existing code seems to be duplicate. Probably missed out because different developers wrote these two sources in different patches. If I were to modify code inside these methods because of my re-factoring, the first thing I would do is to make it into a single common method and avoid duplication. Doesn't matter if I had not written the code, since I am changing it anyway, and can see that it can be improved without too much effort. However I sense that you are not interested in fixing problems in code written by someone else, and are concerned only with the code/api you own. Fair enough! I'll get this fixed in a separate patch. -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
