Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint() ......................................................................
Patch Set 2: The duplicate implementation already existed in the previous code. Please refer to the original code and see. It was hidden as the author wrote the exact same function in two different ways. I just fixed that. I am truly sorry for doing this. So again, nothing had changed, I mean it, NOTHING. And you are totally free to express your opinion. What I ask is to separate between this change, which is retire VdsInstallerSSH, and any other change you may have to improve the current implementation. A bad example of current implementation is that it is not exception based, but this is how author wrote it. Infrastructure components I write will always throw exceptions on errors, even for simple thing like fingerprint. As I wrote in my initial comment, the whole ssh fingerprint should be reworked in future, not now. When re-worked there will be some other mean to achieve the same. But always you will have construct->attributes->connect->fingerprint. -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
