Liron Aravot has posted comments on this change. Change subject: core: WIP: NPEs and wrong persisted information when reusing LUNs ......................................................................
Patch Set 2: (2 inline comments) .................................................... Commit Message Line 4: Commit: Liron Aravot <lara...@redhat.com> Line 5: CommitDate: 2012-11-13 19:25:41 +0200 Line 6: Line 7: core: WIP: NPEs and wrong persisted information when reusing LUNs Line 8: Done Line 9: Generally, the following issues caused that a created lun based storage Line 10: domain when reusing luns led to NPEs and wrong data shown to the user during execution of GetLunsByVgIdQuery. Line 11: Line 12: This patch fixes the following issues: Line 16: Line 17: 2. When extending a domain to use an existing lun, the domain id isn't Line 18: set to that lun which causes to NPE in GetLunsByVgIdQuery or wrong data Line 19: provided to the user. Line 20: it's different - extending/removing. Line 21: 3. When creating a domain from an existing lun, the domain id isn't set Line 22: to this lun which might causes to NPE in GetLunsByVgIdQuery or Line 23: wrong data provided to the user. Line 24: -- To view, visit http://gerrit.ovirt.org/9229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches