Maor Lipchuk has posted comments on this change.
Change subject: core: NPEs and wrong persisted information when reusing LUNs
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
Consider patch set 7 re-factoring request
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 233: public static void proceedLUNInDb(final LUNs lun, StorageType
storageType, String volumeGroupId) {
Line 234: if (DbFacade.getInstance().getLunDao().get(lun.getLUN_id())
== null) {
Line 235: DbFacade.getInstance().getLunDao().save(lun);
Line 236: } else if (!volumeGroupId.isEmpty()){
Line 237:
DbFacade.getInstance().getLunDao().updateLUNsVolumeGroupId(lun.getLUN_id(),
volumeGroupId);
Consider refactoring DbFacade.getInstance().getLunDao() to
StorageHandlingCommandBase.
Line 238: }
Line 239:
Line 240: for (storage_server_connections connection :
lun.getLunConnections()) {
Line 241: List<storage_server_connections> connections =
DbFacade.getInstance()
--
To view, visit http://gerrit.ovirt.org/9229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a0e3c68cb8bd80c2f78ee5aacfccc8c987a79e
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
