Maor Lipchuk has posted comments on this change. Change subject: core:Fix NPE when import VM with clone ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java Line 92: getDiskImage() Line 93: .getId(), Line 94: getParameters().getStorageDomainId(), Line 95: getParameters().getContainerId(), Line 96: getParameters().getOperation(), Move is different then copy. Regarding move we can be sure the disk is already exists, although in copy we don't. IMHO, those two commands should be splited into two different commands in the future. Line 97: getImage().isWipeAfterDelete(), Line 98: getParameters().getForceOverride(), Line 99: getStoragePool() Line 100: .getcompatibility_version().toString())); -- To view, visit http://gerrit.ovirt.org/9176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47b8f82a2bd19320d9953df54f9aa16e4ef9200f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
