Allon Mureinik has posted comments on this change.
Change subject: core:Fix NPE when import VM with clone
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I really don't like this approach.
In order to solve a localized bug, you're opening the door to a whole lot of
others, allowing wipeAfterDelete to be taken from the parameters instead of
from the disk's property.
You could just extract an ifWipeAfterDelete() method in
MoveOrCopyImageGroupCommand to look like this:
private boolean isWipeAfterDelete() {
Image tmp = getImage();
if (tmp == null) {
return false;
}
return tmp.isWipeAfterDelete();
}
--
To view, visit http://gerrit.ovirt.org/9176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b8f82a2bd19320d9953df54f9aa16e4ef9200f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
