ofri masad has posted comments on this change.
Change subject: core: Quota refactor - QuotaManager
......................................................................
Patch Set 12: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 179: return false;
Line 180: }
Line 181: storagePool =
extractStoragePoolFromQuota(parameters.get(0).getQuotaId());
Line 182: }
Line 183: if
(QuotaEnforcementTypeEnum.DISABLED.equals(storagePool.getQuotaEnforcementType()))
{
read it.
looks to me like the old "potatos Vs potatoes". I cant find any conclusive
argument for or against any of the methods. And so it shall remain .equals().
Line 184: return true;
Line 185: }
Line 186: for (StorageQuotaValidationParameter param : parameters) {
Line 187: if (param.getQuotaId() == null ||
Guid.Empty.equals(param.getQuotaId())
--
To view, visit http://gerrit.ovirt.org/8776
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb100467a55b26e4219d1a2562da86b81ffdc032
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
