Greg Padgett has uploaded a new change for review.

Change subject: core: better log when LUN in problem state
......................................................................

core: better log when LUN in problem state

Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8
Bug-Url: https://bugzilla.redhat.com/854214
Signed-off-by: Greg Padgett <gpadg...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
M 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/8880/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
index d35814f..27f33fd 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
@@ -135,7 +135,7 @@
         AuditLogableBase logable = new AuditLogableBase();
 
         String connectionField = getConnectionDescription(connections, 
connection) +
-                (lun == null ? "" : " (LUN " + lun.getphysical_volume_id() + 
")");
+                (lun == null ? "" : " (LUN " + lun.getLUN_id() + ")");
         logable.AddCustomValue("Connection", connectionField);
 
         // Get translated error by error code ,if no translation found (should 
not happened) ,
@@ -184,7 +184,7 @@
             if (connectionGuid.equals(connectionIdGuid)) {
                 String desc = connection.getconnection();
                 if (connection.getiqn() != null) {
-                    desc = desc + " " + connection.getiqn();
+                    desc += " " + connection.getiqn();
                 }
                 return desc;
             }
diff --git 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
index 122fc17..6f51e39 100644
--- 
a/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
+++ 
b/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
@@ -516,7 +516,7 @@
 UPDATE_TAGS_VM_DEFAULT_DISPLAY_TYPE_FAILED=Failed to update Vm ${VmName} tag 
default display type
 CONNECT_STORAGE_SERVERS_FAILED=Failed to connect Host ${VdsName} to Storage 
Servers
 CONNECT_STORAGE_POOL_FAILED=Failed to connect Host ${VdsName} to Storage Pool 
${StoragePoolName}
-STORAGE_DOMAIN_ERROR=The error code for connection ${Connection} returned by 
VDSM was following ${ErrorCode}
+STORAGE_DOMAIN_ERROR=The error message for connection ${Connection} returned 
by VDSM was: ${ErrorCode}
 VDS_LOW_MEM=Available memory of host ${HostName} [${AvailableMemory} MB] is 
under defined threshold [${Threshold} MB].  
 IMPORTEXPORT_FAILED_TO_IMPORT_VM=Failed to read VM '${ImportedVmName}' OVF, it 
may be corrupted
 IMPORTEXPORT_FAILED_TO_IMPORT_TEMPLATE=Failed to read Template '${Template}' 
OVF, it may be corrupted


--
To view, visit http://gerrit.ovirt.org/8880
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief846e766101e0060cb415e6226632c72f7b80f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to