Allon Mureinik has posted comments on this change. Change subject: core: VmReplicateDiskTaskHandler wrong parameter ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java Line 94: getEnclosingCommand().getParameters().getSourceStorageDomainId(), Line 95: getEnclosingCommand().getParameters().getImageGroupID(), Line 96: DbFacade.getInstance() Line 97: .getDiskImageDao() Line 98: .get(getEnclosingCommand().getParameters().getDestinationImageId()) Wait, shouldn't we be deleting the SOURCE image?! Line 99: .isWipeAfterDelete(), Line 100: getEnclosingCommand().getParameters().getForceDelete(), Line 101: null); Line 102: } -- To view, visit http://gerrit.ovirt.org/8942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2e671021cf23aed59bedf27710fb78dc21b4606 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
