Daniel Erez has uploaded a new change for review. Change subject: core: VmReplicateDiskFinishTaskHandler wrong params ......................................................................
core: VmReplicateDiskFinishTaskHandler wrong params VmReplicateDiskFinishTaskHandler -> DeleteImageGroupVDSCommandParameters: DiskImage object should be fetched from DB according to DestinationImageId (instead of ImageGroupID). As a result of an NPE, the source disk wouldn't be deleted; but, should be moved properly. Change-Id: Id2e671021cf23aed59bedf27710fb78dc21b4606 Bug-Url: https://bugzilla.redhat.com/871607 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/8942/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java index eb613d6..b209e21 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java @@ -95,7 +95,7 @@ getEnclosingCommand().getParameters().getImageGroupID(), DbFacade.getInstance() .getDiskImageDao() - .get(getEnclosingCommand().getParameters().getImageGroupID()) + .get(getEnclosingCommand().getParameters().getDestinationImageId()) .isWipeAfterDelete(), getEnclosingCommand().getParameters().getForceDelete(), null); -- To view, visit http://gerrit.ovirt.org/8942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2e671021cf23aed59bedf27710fb78dc21b4606 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
