Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network as Main Tab- (Phase 5)
......................................................................
Patch Set 3: (3 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-29 17:06:39 +0200
Line 4: Commit: Alona Kaplan <alkap...@redhat.com>
Line 5: CommitDate: 2012-10-29 17:11:00 +0200
Line 6:
Line 7: webadmin: Netwrok as Main Tab- (Phase 5)
Done
Line 8:
Line 9: - Main tab - Role- adding custom tooltip.
Line 10: - Cluster sub tab- adding columns and assign/unassign action (using the
Line 11: same models and views and assign/unassign in Cluster->Logical Network)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
Line 8:
Line 9: public class ClusterNetworkModel extends EntityModel {
Line 10:
Line 11: private boolean management;
Line 12: private boolean isAttached = true;
will be done in a cleanup patch
Line 13: private VDSGroup cluster = null;
Line 14:
Line 15: public ClusterNetworkModel(Network network) {
Line 16: setEntity(network);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java
Line 22: Element parent,
Line 23: SafeHtml value,
Line 24: NativeEvent event,
Line 25: ValueUpdater<SafeHtml> valueUpdater) {
Line 26: // TODO Auto-generated method stub
will be done in a cleanup patch
Line 27: super.onBrowserEvent(context, parent, value, event,
valueUpdater);
Line 28: }
Line 29:
Line 30: @Override
--
To view, visit http://gerrit.ovirt.org/8831
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I094f20c080b155da728019098376f4b8f75af1e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
