Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network as Main Tab- (Phase 4)
......................................................................
Patch Set 4: (9 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-29 17:08:44 +0200
Line 4: Commit: Alona Kaplan <alkap...@redhat.com>
Line 5: CommitDate: 2012-10-29 17:11:00 +0200
Line 6:
Line 7: webadmin: Netwrok as Main Tab- (Phase 4)
Done
Line 8:
Line 9: - Update the search syntax in CommanModel.
Line 10: - Change the main tab search to use NetworkView.
Line 11: - Update the columns of the main tab.
Line 5: CommitDate: 2012-10-29 17:11:00 +0200
Line 6:
Line 7: webadmin: Netwrok as Main Tab- (Phase 4)
Line 8:
Line 9: - Update the search syntax in CommanModel.
Done
Line 10: - Change the main tab search to use NetworkView.
Line 11: - Update the columns of the main tab.
Line 12: - Update the General sub tab.
Line 13: - Update the main tab remove action.
Line 10: - Change the main tab search to use NetworkView.
Line 11: - Update the columns of the main tab.
Line 12: - Update the General sub tab.
Line 13: - Update the main tab remove action.
Line 14: - Get ENFINE_NETWROK name synchronously.
Done
Line 15: - Change the tabs order- network tab between Host and Storage tab.
Line 16: - Main tab search order- primary dc_name secondary- network name.
Line 17:
Line 18: Change-Id: I644e9c8f0c5b2d332e1cbccf30545fe152754fee
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java
Line 93: OnPropertyChanged(new
PropertyChangedEventArgs("Description")); //$NON-NLS-1$
Line 94: }
Line 95: }
Line 96:
Line 97: private Guid privateId;
Will be fixed in a cleanup patch
Line 98:
Line 99: public Guid getId()
Line 100: {
Line 101: return privateId;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
Line 78: networkIdParams.setRefresh(getIsQueryFirstTime());
Line 79:
Line 80: if (NetworkHostFilter.unattached.equals(getViewFilterType())){
Line 81: Frontend.RunQuery(VdcQueryType.GetVdsWithoutNetwork,
networkIdParams, _asyncQuery);
Line 82: }else{
It is just the skeleton. The next patches fixes it.
Line 83: // Frontend.RunQuery(VdcQueryType.GetVdsByNetworkId,
networkIdParams, _asyncQuery);
Line 84: }
Line 85: }
Line 86:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java
Line 76: };
Line 77:
Line 78: NetworkIdParameters networkIdParams = new
NetworkIdParameters(getEntity().getNetwork().getId());
Line 79: networkIdParams.setRefresh(getIsQueryFirstTime());
Line 80:
It is just skeleton. It is filled in the next patches.
Line 81: // Frontend.RunQuery(VdcQueryType.GetTemplatesByNetworkId,
networkIdParams, _asyncQuery);
Line 82: }
Line 83:
Line 84:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java
Line 49: {
Line 50: return;
Line 51: }
Line 52:
Line 53: AsyncQuery _asyncQuery = new AsyncQuery();
Will be fixed in a cleanup patch
Line 54: _asyncQuery.setModel(this);
Line 55: _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 56: @Override
Line 57: public void OnSuccess(Object model, Object ReturnValue)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1563: @DefaultStringValue("Unattached")
Line 1564: String unattachedHost();
Line 1565:
Line 1566: // Network
Line 1567: @DefaultStringValue("VM network")
It represents a role, can also be mgmgtNetworkRole.
I think the name is ok.
Line 1568: String vmNetworkRole();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
Line 46:
Line 47: TextColumnWithTooltip<NetworkView> dcColumn = new
TextColumnWithTooltip<NetworkView>() {
Line 48: @Override
Line 49: public String getValue(NetworkView object) {
Line 50: return object.getStoragePoolName(); //$NON-NLS-1$
Done
Line 51: }
Line 52: };
Line 53:
Line 54: getTable().addColumn(dcColumn, constants.dcNetwork());
--
To view, visit http://gerrit.ovirt.org/8741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I644e9c8f0c5b2d332e1cbccf30545fe152754fee
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
