Gilad Chaplik has posted comments on this change.

Change subject: webadmin: KSM enabled checkbox alway start unchecked
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42410/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java:

Line 1138:                     
getKsmPolicyForNumaSelection().setIsChangeable(true);
Line 1139:                 }
Line 1140:                 if (getEnableKsm().getEntity() == false){
Line 1141:                     
getKsmPolicyForNumaSelection().setIsChangeable(false);
Line 1142:                 }
please try to avoid unnecessary changes to next patches.
Line 1143:             }
Line 1144:         });
Line 1145: 
Line 1146:         setEnableBallooning(new EntityModel<Boolean>());


-- 
To view, visit https://gerrit.ovirt.org/42410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e40cfb58b9510042c49f7617f01148b63ef79c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <d...@redhat.com>
Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to