Dudi Maroshi has uploaded a new change for review. Change subject: webadmin: KSM enabled checkbox alway start unchecked ......................................................................
webadmin: KSM enabled checkbox alway start unchecked Problem: KSM enablement checkbox always start unchecked. Solution: Remove default disablment in version compatability handling Change-Id: I1e40cfb58b9510042c49f7617f01148b63ef79c9 Bug-Url: https://bugzilla.redhat.com/840114 Signed-off-by: Dudi Maroshi <d...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/42410/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java index f7e11a5..c07c38d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java @@ -1131,12 +1131,15 @@ getEnableKsm().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { @Override public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { - if (getEnableKsm().getEntity() == null) + if (getEnableKsm().getEntity() == null){ return; - if (getEnableKsm().getEntity() == true) + } + if (getEnableKsm().getEntity() == true){ getKsmPolicyForNumaSelection().setIsChangeable(true); - if (getEnableKsm().getEntity() == false) + } + if (getEnableKsm().getEntity() == false){ getKsmPolicyForNumaSelection().setIsChangeable(false); + } } }); @@ -1717,8 +1720,6 @@ boolean isSmallerThanVersion3_4 = version.compareTo(Version.v3_4) < 0; getEnableKsm().setIsChangeable(!isSmallerThanVersion3_4); getEnableKsm().setChangeProhibitionReason(ConstantsManager.getInstance().getConstants().ksmNotAvailable()); - // default is false (disabled) - getEnableKsm().setEntity(false); // for version 3.3 and lower the default is true. if (isSmallerThanVersion3_4) { getEnableKsm().setEntity(true); -- To view, visit https://gerrit.ovirt.org/42410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e40cfb58b9510042c49f7617f01148b63ef79c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
