Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: let the user configure the appliance vCPU value ......................................................................
Patch Set 6: Verified-1 -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/42158/6/src/plugins/ovirt-hosted-engine-setup/vm/cpu.py File src/plugins/ovirt-hosted-engine-setup/vm/cpu.py: Line 95: default_msg = _('minimum requirement') Line 96: if self.environment[ Line 97: ohostedcons.VMEnv.APPLIANCEVCPUS Line 98: ] is not None: Line 99: default = ohostedcons.VMEnv.APPLIANCEVCPUS Please specify the number of virtual CPUs for the VM [Defaults to appliance OVF value: OVEHOSTED_VM/applianceVCpus]: missing access to the environment. fixing. Line 100: default_msg = _('appliance OVF value') Line 101: Line 102: while not valid: Line 103: if interactive: -- To view, visit https://gerrit.ovirt.org/42158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee514e9066d69852a60e606a93f6a59e23e26c87 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
