Juan Hernandez has posted comments on this change. Change subject: engine: Add KSM policy to NUMA hosts ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42373/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-06-15 07:29:28 -0400 Line 6: Line 7: engine: Add KSM policy to NUMA hosts Line 8: Line 9: Fix redundent import statement, and mistakenly skipped rebase Is this the right commit message? I don't see this patch touching NUM nodes, or fixing redundant imports. Line 10: Line 11: Bug-Url: https://bugzilla.redhat.com/840114 Line 12: Change-Id: I23aee2305902c0dcfc4dbf89221e4c60a4acf602 https://gerrit.ovirt.org/#/c/42373/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java: Line 168: model.setMaintenanceReasonRequired(entity.isMaintenanceReasonRequired()); Line 169: model.setBallooningEnabled(entity.isEnableBallooning()); Line 170: model.setKsm(new KSM()); Line 171: model.getKsm().setEnabled(entity.isEnableKsm()); Line 172: model.getKsm().setMergeAcrossNodes(entity.isKsmMergeAcrossNumaNodes()); This is a good opportunity to make this a bit better, in particular it isn't good to blindlly assing a new KSM object, better check if it is needed: KSM ksm = model.getKsm(); if (ksm == null) { ksm = new KSM(); model.setKsm(ksm); } ksm.setEnabled(...); ksm.setMergeAcrossNodes(...); Line 173: if (StringUtils.isNotBlank(entity.getSpiceProxy())) { Line 174: Display display = new Display(); Line 175: display.setProxy(entity.getSpiceProxy()); Line 176: model.setDisplay(display); -- To view, visit https://gerrit.ovirt.org/42373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23aee2305902c0dcfc4dbf89221e4c60a4acf602 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
