Tomer Saban has posted comments on this change. Change subject: core:Added affinity Group collision validation. ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/41805/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java: Line 57: Line 58: return hasAffinityCollisions(getParameters()); Line 59: } Line 60: Line 61: private Boolean hasAffinityCollisions(AffinityGroupCRUDParameters parameters) { > boolean Done Line 62: List<AffinityGroup> affinityGroups = getAllAffinityGroups(parameters.getAffinityGroup().getClusterId()); Line 63: affinityGroups.add(parameters.getAffinityGroup()); Line 64: return getUnifiedAffinityGroups(affinityGroups); Line 65: } Line 57: Line 58: return hasAffinityCollisions(getParameters()); Line 59: } Line 60: Line 61: private Boolean hasAffinityCollisions(AffinityGroupCRUDParameters parameters) { > boolean Done Line 62: List<AffinityGroup> affinityGroups = getAllAffinityGroups(parameters.getAffinityGroup().getClusterId()); Line 63: affinityGroups.add(parameters.getAffinityGroup()); Line 64: return getUnifiedAffinityGroups(affinityGroups); Line 65: } Line 77: #### if size of the intersection of group from UAG and the negative group is > 1: Line 78: ##### throw exception “Affinity group contradiction detected” (With associated groups). Line 79: Line 80: */ Line 81: private Boolean getUnifiedAffinityGroups(List<AffinityGroup> affinityGroups) { > boolean not Boolean Done Line 82: Set<Set<Guid>> uag = new HashSet(); Line 83: Line 84: //uag = {{vm} for each vm in any affinity group(Either negative or positive)} Line 85: for(AffinityGroup ag: affinityGroups) { https://gerrit.ovirt.org/#/c/41805/7/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3724: Line 3725: @DefaultStringValue("VM is associated with both positive and negative Affinity Groups, please reconfigure VM's affinity groups") Line 3726: String ACTION_TYPE_FAILED_MIX_POSITIVE_NEGATIVE_AFFINITY_GROUP(); Line 3727: Line 3728: @DefaultStringValue("Affinity Group contradiction detected between UAG:\n${UAG}\nand negative Affinity Group:\n${negativeAR}") > nobody knows what UAG is. Done Line 3729: String ACTION_TYPE_FAILED_AFFINITY_RULES_COLLISION(); Line 3730: Line 3731: @DefaultStringValue("iSCSI bond name must not exceed 50 characters") Line 3732: String VALIDATION_ISCSI_BOND_NAME_MAX(); -- To view, visit https://gerrit.ovirt.org/41805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c483023ed14e238c8a67ec0890812158ecd0b2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
